From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44F54C3A59D for ; Thu, 22 Aug 2019 10:46:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25F8F206B7 for ; Thu, 22 Aug 2019 10:46:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732376AbfHVKqf (ORCPT ); Thu, 22 Aug 2019 06:46:35 -0400 Received: from ozlabs.org ([203.11.71.1]:60267 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731416AbfHVKqe (ORCPT ); Thu, 22 Aug 2019 06:46:34 -0400 Received: by ozlabs.org (Postfix, from userid 1034) id 46Dh6J1Yyqz9sNy; Thu, 22 Aug 2019 20:46:31 +1000 (AEST) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 8d4ba9c931bc384bcc6889a43915aaaf19d3e499 In-Reply-To: <20190813100100.GC9567@blackberry> To: Paul Mackerras , linuxppc-dev@ozlabs.org, kvm@vger.kernel.org From: Michael Ellerman Cc: kvm-ppc@vger.kernel.org, David Gibson Subject: Re: [PATCH v2 2/3] KVM: PPC: Book3S HV: Don't push XIVE context when not using XIVE device Message-Id: <46Dh6J1Yyqz9sNy@ozlabs.org> Date: Thu, 22 Aug 2019 20:46:31 +1000 (AEST) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 2019-08-13 at 10:01:00 UTC, Paul Mackerras wrote: > At present, when running a guest on POWER9 using HV KVM but not using > an in-kernel interrupt controller (XICS or XIVE), for example if QEMU > is run with the kernel_irqchip=off option, the guest entry code goes > ahead and tries to load the guest context into the XIVE hardware, even > though no context has been set up. > > To fix this, we check that the "CAM word" is non-zero before pushing > it to the hardware. The CAM word is initialized to a non-zero value > in kvmppc_xive_connect_vcpu() and kvmppc_xive_native_connect_vcpu(), > and is now cleared in kvmppc_xive_{,native_}cleanup_vcpu. > > Cc: stable@vger.kernel.org # v4.11+ > Reported-by: Cédric Le Goater > Fixes: 5af50993850a ("KVM: PPC: Book3S HV: Native usage of the XIVE interrupt controller") > Signed-off-by: Paul Mackerras > Reviewed-by: Cédric Le Goater Applied to powerpc topic/ppc-kvm, thanks. https://git.kernel.org/powerpc/c/8d4ba9c931bc384bcc6889a43915aaaf19d3e499 cheers