From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC][PATCH 0/7] guest SMP with in-kernel APIC Date: Sun, 09 Sep 2007 10:58:24 +0300 Message-ID: <46E3A7A0.90203@qumranet.com> References: <37E52D09333DE2469A03574C88DBF40FA9C206@pdsmsx414.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "He, Qing" Return-path: In-Reply-To: <37E52D09333DE2469A03574C88DBF40FA9C206-wq7ZOvIWXbM/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org He, Qing wrote: > Avi, > During the rebase to lapic6, I saw two patches missing in this branch. Please see the attachments. > > For the p1 patch, it was Sheng's patch to fix x86_64 windows booting. I believe the commit 948a4b9e4b in kernel side (disable tpr/cr8 sync when in-kernel APIC is used) also addresses this issue, but from code point of view, this user mode patch is just OK, I see no reason to remove it. (btw., my original update on the patch is unnecessary, you can just drop that update). > > For the p2 patch, it was applied by you, and it's necessary for kernel apic SMP. Please reapply it to lapic6, and it can be folded and merged with kvm-userspace commit 314694c464 (conditionally bypass user level init/sipi handling). > > There is also a regression on SMP introduced by hrtimer migration. We are currently working on it and will send it out later as separate patch set. > > Applied both, thanks. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/