From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/5] Clean up unloved invlpg: remove kvm_arch_ops.invlpg and tweak emulator. Date: Sun, 09 Sep 2007 14:13:12 +0300 Message-ID: <46E3D548.4030402@qumranet.com> References: <1189005567.10802.127.camel@localhost.localdomain> <46DECBA7.7020905@qumranet.com> <1189009359.10802.157.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Rusty Russell Return-path: In-Reply-To: <1189009359.10802.157.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Rusty Russell wrote: > On Wed, 2007-09-05 at 18:30 +0300, Avi Kivity wrote: > >> Rusty Russell wrote: >> >>> invlpg shouldn't fetch the "src" address, since it may not be valid, >>> however SVM's "solution" which neuters emulation of all group 7 >>> instruction is horrible and breaks kvm-lite. The simplest fix is to >>> put a special check in for invlpg. >>> >>> Also, remove the unused invlpg member of struct kvm_arch_ops. >>> >>> >>> >> One change, one patch. >> > > > Applied both halves, thanks. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/