From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC][PATCH 5/6][KVM VIRTIO] Add the network device code Date: Sun, 09 Sep 2007 15:58:42 +0300 Message-ID: <46E3EE02.30405@qumranet.com> References: <64F9B87B6B770947A9F8391472E032160D59005E@ehost011-8.exch011.intermedia.net> <68676e00708281252m64116588q996e1d2079632cfd@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Luca Return-path: In-Reply-To: <68676e00708281252m64116588q996e1d2079632cfd-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Luca wrote: > On 8/25/07, Dor Laor wrote: > > I just noticed this: > > >> --- /dev/null >> +++ b/qemu/hw/paravirt_net.c >> @@ -0,0 +1,213 @@ >> +/* >> + * QEMU para virtual network emulation >> + * >> + * Copyright (c) 2007 Qumranet >> + * >> + * Permission is hereby granted, free of charge, to any person >> obtaining a copy >> + * of this software and associated documentation files (the >> "Software"), to deal >> + * in the Software without restriction, including without limitation >> the rights >> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or >> sell >> + * copies of the Software, and to permit persons to whom the Software >> is >> + * furnished to do so, subject to the following conditions: >> + * >> + * The above copyright notice and this permission notice shall be >> included in >> + * all copies or substantial portions of the Software. >> > [cut] > > Shouldn't you use the standard GPL boilerplate? (IANAL, so maybe the > text above is a superset of the GPL and is fine...) > > My preference is to just add a copyright and refer to some file in the top-level, so we don't restrict qemu's licensing unnecessarily (this could hinder merging). -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/