From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] Re: expose host CPU features to guests Date: Sun, 09 Sep 2007 19:38:43 +0300 Message-ID: <46E42193.5020301@qumranet.com> References: <20070905174530.GA3945@karma.qumranet.com> <200709091625.59859.paul@codesourcery.com> <46E4114C.6090804@qumranet.com> <200709091712.15743.paul@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org To: Paul Brook Return-path: In-Reply-To: <200709091712.15743.paul-qD8j1LwMmJjtCj0u4l0SBw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Paul Brook wrote: >>> What you really want to do is ask your virtualization module what >>> features it supports. >>> >> Yes, that needs to be an additional filter. >> > > I'd have thought that would be the *only* interesting set for autodetection. > > Yes, you're right. It's pointless to issue cpuid in userspace and mask it in the kernel; rather we can issue it in the kernel , mask out unsupported features, and return it to userspace. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/