kvm: Unknown symbol genapic

kvm: Unknown symbol genapic

[Zhao, Yunfeng]

I can compile latest kvm.git as external modules of 2.6.22 kernel
successfully.
But I cannot insert kvm.ko.
It failed with the error:
kvm: Unknown symbol genapic


thanks
Yunfeng

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Re: kvm: Unknown symbol genapic

[Avi Kivity]

Zhao, Yunfeng wrote:
> I can compile latest kvm.git as external modules of 2.6.22 kernel
> successfully.
> But I cannot insert kvm.ko.
> It failed with the error:
> kvm: Unknown symbol genapic
>
>   

Is this on i386 or x86_64?




-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Re: kvm: Unknown symbol genapic

[Zhao, Yunfeng]

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]

It's on x86_64.

Thanks
Yunfeng

>-----Original Message-----
>From: Avi Kivity [mailto:avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org]
>Sent: 2007年9月10日 23:15
>To: Zhao, Yunfeng
>Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>Subject: Re: [kvm-devel] kvm: Unknown symbol genapic
>
>Zhao, Yunfeng wrote:
>> I can compile latest kvm.git as external modules of 2.6.22 kernel
>> successfully.
>> But I cannot insert kvm.ko.
>> It failed with the error:
>> kvm: Unknown symbol genapic
>>
>>
>
>Is this on i386 or x86_64?
>
>
>
>
>--
>error compiling committee.c: too many arguments to function


[-- Attachment #2: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: kvm: Unknown symbol genapic

[Simon Gao]

[-- Attachment #1: Type: text/plain, Size: 884 bytes --]

Zhao, Yunfeng wrote:
> It's on x86_64.
>
> Thanks
> Yunfeng
>
>   
>> -----Original Message-----
>> From: Avi Kivity [mailto:avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org]
>> Sent: 2007年9月10日 23:15
>> To: Zhao, Yunfeng
>> Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>> Subject: Re: [kvm-devel] kvm: Unknown symbol genapic
>>
>> Zhao, Yunfeng wrote:
>>     
>>> I can compile latest kvm.git as external modules of 2.6.22 kernel
>>> successfully.
>>> But I cannot insert kvm.ko.
>>> It failed with the error:
>>> kvm: Unknown symbol genapic
>>>
>>>
>>>       
>> Is this on i386 or x86_64?
>>
>>
>>
>>     
I had the same problem with kernel-2.6.22-gentoo-r5. Applied the patch
from the email titled
"kvm-37 problem w/ 64-bit division in lapic.c" and fixed the problem.

So check it out.

Simon


















[-- Attachment #2: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: kvm: Unknown symbol genapic

[Dong, Eddie]

[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]

>> 
>> Zhao, Yunfeng wrote:
>>> I can compile latest kvm.git as external modules of 2.6.22 kernel
>>> successfully. But I cannot insert kvm.ko.
>>> It failed with the error:
>>> kvm: Unknown symbol genapic
>>> 
>>> 
>> 
>> Is this on i386 or x86_64?
>> 
>> 

GET_APIC_ID may use genapic instance for some machine
configuration in i386 architecture, but it is not exported
for outside usage. This patch remove this reference.

Signed-off-by: Yaozu(Eddie) Dong <eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

diff --git a/drivers/kvm/lapic.c b/drivers/kvm/lapic.c
index a894dee..84bc4e3 100644
--- a/drivers/kvm/lapic.c
+++ b/drivers/kvm/lapic.c
@@ -110,7 +110,7 @@ static inline int apic_enabled(struct kvm_lapic
*apic)
 
 static inline int kvm_apic_id(struct kvm_lapic *apic)
 {
-	return GET_APIC_ID(apic_get_reg(apic, APIC_ID));
+	return (apic_get_reg(apic, APIC_ID) >> 24) & 0xf;
 }
 
 static inline int apic_lvt_enabled(struct kvm_lapic *apic, int
lvt_type)

[-- Attachment #2: genapic.patch --]
[-- Type: application/octet-stream, Size: 680 bytes --]

GET_APIC_ID may use genapic instance for some machine
configuration in i386 architecture, but it is not exported
for outside usage. This patch remove this reference.

Signed-off-by: Yaozu(Eddie) Dong <eddie.dong@intel.com>

diff --git a/drivers/kvm/lapic.c b/drivers/kvm/lapic.c
index a894dee..84bc4e3 100644
--- a/drivers/kvm/lapic.c
+++ b/drivers/kvm/lapic.c
@@ -110,7 +110,7 @@ static inline int apic_enabled(struct kvm_lapic *apic)
 
 static inline int kvm_apic_id(struct kvm_lapic *apic)
 {
-	return GET_APIC_ID(apic_get_reg(apic, APIC_ID));
+	return (apic_get_reg(apic, APIC_ID) >> 24) & 0xf;
 }
 
 static inline int apic_lvt_enabled(struct kvm_lapic *apic, int lvt_type)

[-- Attachment #3: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #4: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: kvm: Unknown symbol genapic

[Dong, Eddie]

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

Made a wrong copy from old i386. the mask should be 0xff and clear in
debug message too. reattached.

> 
> GET_APIC_ID may use genapic instance for some machine
> configuration in i386 architecture, but it is not exported
> for outside usage. This patch remove this reference.
> 
> Signed-off-by: Yaozu(Eddie) Dong <eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 
> diff --git a/drivers/kvm/lapic.c b/drivers/kvm/lapic.c
> index a894dee..84bc4e3 100644
> --- a/drivers/kvm/lapic.c
> +++ b/drivers/kvm/lapic.c
> @@ -110,7 +110,7 @@ static inline int apic_enabled(struct kvm_lapic
> *apic) 
> 
> static inline int kvm_apic_id(struct kvm_lapic *apic) {
> -	return GET_APIC_ID(apic_get_reg(apic, APIC_ID));
> +	return (apic_get_reg(apic, APIC_ID) >> 24) & 0xf; }
> 
> static inline int apic_lvt_enabled(struct kvm_lapic *apic, int
> lvt_type)


[-- Attachment #2: genapic.patch --]
[-- Type: application/octet-stream, Size: 1035 bytes --]

GET_APIC_ID may use genapic instance for some machine
configuration in i386 architecture, but it is not exported
for outside usage. This patch remove this reference.

Signed-off-by: Yaozu(Eddie) Dong <eddie.dong@intel.com>

diff --git a/drivers/kvm/lapic.c b/drivers/kvm/lapic.c
index a894dee..472a1c7 100644
--- a/drivers/kvm/lapic.c
+++ b/drivers/kvm/lapic.c
@@ -110,7 +110,7 @@ static inline int apic_enabled(struct kvm_lapic *apic)
 
 static inline int kvm_apic_id(struct kvm_lapic *apic)
 {
-	return GET_APIC_ID(apic_get_reg(apic, APIC_ID));
+	return (apic_get_reg(apic, APIC_ID) >> 24) & 0xff;
 }
 
 static inline int apic_lvt_enabled(struct kvm_lapic *apic, int lvt_type)
@@ -859,7 +859,7 @@ void kvm_lapic_reset(struct kvm_vcpu *vcpu)
 
 	apic_debug(KERN_INFO "%s: vcpu=%p, id=%d, base_msr="
 		   "0x%016" PRIx64 ", base_address=0x%0lx.\n", __FUNCTION__,
-		   vcpu, GET_APIC_ID(apic_get_reg(apic, APIC_ID)),
+		   vcpu, kvm_apic_id(apic),
 		   vcpu->apic_base, apic->base_address);
 }
 EXPORT_SYMBOL_GPL(kvm_lapic_reset);

[-- Attachment #3: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #4: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: kvm: Unknown symbol genapic

[Avi Kivity]

Dong, Eddie wrote:
> Made a wrong copy from old i386. the mask should be 0xff and clear in
> debug message too. reattached.
>
>   
>> GET_APIC_ID may use genapic instance for some machine
>> configuration in i386 architecture, but it is not exported
>> for outside usage. This patch remove this reference.
>>
>>     

Applied, thanks.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Re: kvm: Unknown symbol genapic

[Avi Kivity]

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

Zhao, Yunfeng wrote:
> It's on x86_64.
>
>   

This ought to be fixed on kvm-38 (patch from Eddie).

-- 
error compiling committee.c: too many arguments to function



[-- Attachment #2: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: kvm: Unknown symbol genapic

[Zhao, Yunfeng]

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

Yes, I tested the patch. It works well.

>-----Original Message-----
>From: Avi Kivity [mailto:avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org]
>Sent: 2007年9月12日 17:36
>To: Zhao, Yunfeng
>Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>Subject: Re: [kvm-devel] kvm: Unknown symbol genapic
>
>Zhao, Yunfeng wrote:
>> It's on x86_64.
>>
>>
>
>This ought to be fixed on kvm-38 (patch from Eddie).
>
>--
>error compiling committee.c: too many arguments to function


[-- Attachment #2: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel