Re: [ANNOUNCE] kvm-36 release

Izik Eidus
2007-08-23T00:36:04Z

[-- Attachment #1: Type: text/plain, Size: 854 bytes --]

On Thu, 2007-08-23 at 11:12 +0300, Avi Kivity wrote:
> Avi Kivity wrote:
> > Gunther Persoons wrote:
> >> I noticed the idle cpu usage for kvm-36 running windows xp 32 bit as
> >> guest is much higher.
> >> For kvm-35 this was around 2-4%, running kvm-36 it's 22% - 26%.
> >>
> >>
> >
> > Hmm. Is this using the ACPI HAL, or the Standard PC HAL, or what?
> >
> > The fix was targeted at ACPI MP HALs (reducing cpu usage from 100% to
> > something sane).
> >
>
>
> Looks like a vga regression introduced by support for large memory.
> Does the attached patch fix?
>

avi, try this patch,
the problem was that page_max is set to -1 inside the code,
and when the code changed page0 and page1 to unsigned long, it never
entered to there.

the patch that i give now, is one way to fix it (ofcourse there is
another way to play with casting.)

>
>

[-- Attachment #2: vga_fix --]
[-- Type: text/x-patch, Size: 642 bytes --]

--- oldvga.c 2007-08-23 03:22:30.000000000 +0300
+++ vga.c 2007-08-23 03:28:58.000000000 +0300
@@ -1400,12 +1400,12 @@ extern int kvm_allowed;
*/
static void vga_draw_graphic(VGAState *s, int full_update)
{
- int y1, y, update, page_min, page_max, linesize, y_start, double_scan, mask;
+ int y1, y, update, linesize, y_start, double_scan, mask;
int width, height, shift_control, line_offset, bwidth;
int disp_width, multi_scan, multi_run;
uint8_t *d;
uint32_t v, addr1, addr;
- ram_addr_t page0, page1;
+ long page0, page1, page_min, page_max;
vga_draw_line_func *vga_draw_line;

#ifdef USE_KVM

[-- Attachment #3: Type: text/plain, Size: 315 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

[-- Attachment #4: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org