public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Detect arch dynamically from uname instead of using hardcoded x86_64 value
@ 2007-09-16  9:49 Carlo Marcelo Arenas Belon
  2007-09-16 10:00 ` Avi Kivity
  0 siblings, 1 reply; 2+ messages in thread
From: Carlo Marcelo Arenas Belon @ 2007-09-16  9:49 UTC (permalink / raw)
  To: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

The following patch is part of a series of fixes used to allow for the use of
the kvm python wrapper in Gentoo Linux.

In this case the value for the architecture used is retrieved from uname and
used to identify the right qemu system binary name.

Carlo

Signed-off-by: Carlo Marcelo Arenas Belon <carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org>
---
 kvm |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/kvm b/kvm
index 0b509f6..d349efe 100755
--- a/kvm
+++ b/kvm
@@ -184,7 +184,8 @@ bootdisk = 'c'
 if options.install:
     bootdisk = 'd'
 
-arch = 'x86_64'
+uname = os.uname()
+arch = uname[4]
 
 if arch == 'x86_64':
     cmd = 'qemu-system-' + arch
-- 
1.5.1.6


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Detect arch dynamically from uname instead of using hardcoded x86_64 value
  2007-09-16  9:49 [PATCH] Detect arch dynamically from uname instead of using hardcoded x86_64 value Carlo Marcelo Arenas Belon
@ 2007-09-16 10:00 ` Avi Kivity
  0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2007-09-16 10:00 UTC (permalink / raw)
  To: Carlo Marcelo Arenas Belon; +Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

Carlo Marcelo Arenas Belon wrote:
> The following patch is part of a series of fixes used to allow for the use of
> the kvm python wrapper in Gentoo Linux.
>
> In this case the value for the architecture used is retrieved from uname and
> used to identify the right qemu system binary name.
>
> Carlo
>
> Signed-off-by: Carlo Marcelo Arenas Belon <carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org>
> ---
>  kvm |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/kvm b/kvm
> index 0b509f6..d349efe 100755
> --- a/kvm
> +++ b/kvm
> @@ -184,7 +184,8 @@ bootdisk = 'c'
>  if options.install:
>      bootdisk = 'd'
>  
> -arch = 'x86_64'
> +uname = os.uname()
> +arch = uname[4]
>   

We always compile kvm for the x86_64 target.  So this will select a 
nonexisting binary.


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-09-16 10:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-16  9:49 [PATCH] Detect arch dynamically from uname instead of using hardcoded x86_64 value Carlo Marcelo Arenas Belon
2007-09-16 10:00 ` Avi Kivity

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox