From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Add support for a basic boot menu to the bios Date: Mon, 17 Sep 2007 19:30:26 +0200 Message-ID: <46EEB9B2.7050108@qumranet.com> References: <1189626953.16586.6.camel@localhost.localdomain> <46ED8B5B.40903@qumranet.com> <68676e00709170823m3247c3eaj7d268166ecc8c013@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , Jeremy Katz To: Luca Return-path: In-Reply-To: <68676e00709170823m3247c3eaj7d268166ecc8c013-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Luca wrote: > On 9/16/07, Avi Kivity wrote: > >> - coding this stuff in rombios32.c instead of rombios.c (with its >> strange idea of C) is *much* preferable for maintainability. >> > > The strange code style is due to the compiler used (bcc). I see that > today it's possible to make as and gcc to emit 16bit code (e.g. HPA > rewrote i386 boot code in plain C)... > > It's simpler and better to code it in 32-bit mode in rombios32.c, where there are no restrictions like with the 16-bit mode. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/