From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 001/104] KVM: Fix *nopage() in kvm_main.c Date: Mon, 17 Sep 2007 20:19:23 +0200 Message-ID: <46EEC52B.8080101@qumranet.com> References: <11900179463203-git-send-email-avi@qumranet.com> <46EE45C3.8040302@qumranet.com> <46EE4683.7070205@qumranet.com> <200709170729.24835.nickpiggin@yahoo.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Christoph Hellwig , kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Nick Piggin Return-path: In-Reply-To: <200709170729.24835.nickpiggin-/E1597aS9LT0CCvOHzKKcA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Nick Piggin wrote: >> >> I should mention that the converting to use ->fault() is a 15-minute >> change; the tricky part is adding backwards compatibility for the >> external module package. >> > > It should be mostly possible to ifdef a nopage() handler, which is > just a wrapper function to translate arguments then call your new > ->fault() handler. With luck, fault would mostly inline into nopage, > and do some constant folding to make it cheaper... > > I'm planning to go through and convert the rest of the in-tree users > at some point soon, so if you do get a chance to convert your > upstream code before I try, it would nice ;) > > In kvm I don't add compatibility #ifdefs to mainline, instead I have an awk script that massages the sources into something that all kernels can grok. It isn't pretty but it works. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/