From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Vivier Subject: Re: [PATCH 0/5][RESEND] Split the emulator: decode & execute Date: Tue, 18 Sep 2007 12:28:24 +0200 Message-ID: <46EFA848.9020105@bull.net> References: <46EF99C1.4070801@bull.net> <46EFA593.2010706@qumranet.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0204996707==" Cc: kvm-devel To: Avi Kivity Return-path: In-Reply-To: <46EFA593.2010706-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --===============0204996707== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig90EA3E66A7AB62E5F22099B7" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig90EA3E66A7AB62E5F22099B7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > Laurent Vivier wrote: >> These patches split the emulator in two parts: one to decode the instr= uction, >> the other to execute it. The decode part is then called only when need= ed. >> >> =20 >=20 > Applied all, thanks. >=20 > I changed the name of the variable 'decode' to 'c' to reduce the number= =20 > of line splits. No problem > This patchset, in addition to the correctness issues, also enables=20 > further cleaning up of x86_emulate.c: since most variables are now in a= =20 > structure, chunks of the code can be moved to a separate function that = > takes just the decode cache. This will reduce > the high indent level and increase readability. I can do that too. Laurent --=20 ------------- Laurent.Vivier-6ktuUTfB/bM@public.gmane.org -------------- "Software is hard" - Donald Knuth --------------enig90EA3E66A7AB62E5F22099B7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.7 (GNU/Linux) iD8DBQFG76hL9Kffa9pFVzwRAq9GAKCmKmauz0uW63N+yo0wHR8ktjFlWgCfXfIk YcHYNeYGxuUEBtIkVzooGu0= =QUQA -----END PGP SIGNATURE----- --------------enig90EA3E66A7AB62E5F22099B7-- --===============0204996707== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ --===============0204996707== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel --===============0204996707==--