Re: [kvm-commits] KVM: Fix ioapic level-triggered interrupt redelivery

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Dong, Eddie wrote:
> Avi Kivity wrote:
>   
>> Avi Kivity wrote:
>>     
>>>> Also architectually level = 0 may also mean an IRQ to IOAPIC
>>>>  if the polarity is negative though today we may not see this. But
>>>> this change will expose the risk, and the propose of pass-through
>>>>  hardware device will change the polarity.
>>>>
>>>>         
>>> Sure, if you run Xen + pci passthrough with the polarity reversal on
>>> kvm :) 
>>>
>>> We do want a correct polarity implementation -- I'll do that later
>>> on.  I certainly won't say no to patches...
>>>
>>>       
>> Can't we just do
>>
>>
>>    level ^= polarity;
>>
>> at the beginning of the function?  Then reversed polarity interrupts
>> use the same code as normal interrupts.
>>
>>     
> Yes, let ioapic->irr indicate the interrupt line state since we need it
> for both level and edge. Then use above logic for the next interrupt
> generation logic :-)
>   

So committed.

Thanks.


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/