From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] move grp decoding to functions to make x86_emulate_insn() clearer Date: Thu, 20 Sep 2007 19:43:05 +0200 Message-ID: <46F2B129.9060603@qumranet.com> References: <46EF99C1.4070801@bull.net> <11903005973031-git-send-email-Laurent.Vivier@bull.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Laurent Vivier Return-path: In-Reply-To: <11903005973031-git-send-email-Laurent.Vivier-6ktuUTfB/bM@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Laurent Vivier wrote: > To improve readability, move push, writeback, and grp 1a/2/3/4/5 emulation parts to functions. > +static inline int emulate_grp45(struct x86_emulate_ctxt *ctxt, > + struct x86_emulate_ops *ops, > + unsigned long *_eflags, > + int *no_wb) > If you move _eflags and no_wb to the decode cache (in a separate patch) then this patch can be much nicer. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/