From: Laurent Vivier <Laurent.Vivier-6ktuUTfB/bM@public.gmane.org>
To: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] move grp decoding to functions to make x86_emulate_insn() clearer
Date: Thu, 20 Sep 2007 20:24:25 +0200 [thread overview]
Message-ID: <46F2BAD9.1080209@bull.net> (raw)
In-Reply-To: <46F2B129.9060603-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Avi Kivity wrote:
> Laurent Vivier wrote:
>> To improve readability, move push, writeback, and grp 1a/2/3/4/5 emulation parts to functions.
>> +static inline int emulate_grp45(struct x86_emulate_ctxt *ctxt,
>> + struct x86_emulate_ops *ops,
>> + unsigned long *_eflags,
>> + int *no_wb)
>>
>
> If you move _eflags and no_wb to the decode cache (in a separate patch)
> then this patch can be much nicer.
I agree but this increases the size of the structure shared with the
userspace with variable used only locally in x86_emulate.c, is it
acceptable ?
Laurent
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2007-09-20 18:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-18 9:26 [PATCH 0/5][RESEND] Split the emulator: decode & execute Laurent Vivier
[not found] ` <46EF99C1.4070801-6ktuUTfB/bM@public.gmane.org>
2007-09-18 10:16 ` Avi Kivity
[not found] ` <46EFA593.2010706-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-09-18 10:28 ` Laurent Vivier
2007-09-20 15:03 ` [PATCH] move grp decoding to functions to make x86_emulate_insn() clearer Laurent Vivier
[not found] ` <11903005973031-git-send-email-Laurent.Vivier-6ktuUTfB/bM@public.gmane.org>
2007-09-20 17:43 ` Avi Kivity
[not found] ` <46F2B129.9060603-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-09-20 18:24 ` Laurent Vivier [this message]
[not found] ` <46F2BAD9.1080209-6ktuUTfB/bM@public.gmane.org>
2007-09-20 18:25 ` Avi Kivity
[not found] ` <46F2BB21.2080209-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-09-20 18:47 ` Laurent Vivier
[not found] ` <46F2C053.90207-6ktuUTfB/bM@public.gmane.org>
2007-09-20 18:55 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F2BAD9.1080209@bull.net \
--to=laurent.vivier-6ktuutfb/bm@public.gmane.org \
--cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox