Re: [ANNOUNCE] kvm-44 release

Farkas Levente
2007-09-24T08:37:01Z

> Farkas Levente wrote:
>> Avi Kivity wrote:
>>
>>> Farkas Levente wrote:
>>>
>>>> Avi Kivity wrote:
>>>>
>>>>
>>>>> An important fix to guest smp (it boots now!), and a performance
>>>>> improvement on Intel hardware. I get about 5% boost on a kernel
>>>>> build.
>>>>>
>>>>> There's a new module parameter to kvm-intel.ko that can disable this
>>>>> mechanism, bypass_guest_pf. Load the module with bypass_guest_pf=0
>>>>> to disable the optimization. It shouldn't be necessary to do that on
>>>>> current processors; it's mostly to protect kvm against changes in
>>>>> hardware since the patch uses reserved bits.
>>>>>
>>>> make[1]: Entering directory `/usr/src/kernels/2.6.18-8.1.10.el5-x86_64'
>>>> LD
>>>> /home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/built-in.o
>>>> CC [M] /home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/svm.o
>>>> CC [M] /home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/vmx.o
>>>> CC [M]
>>>> /home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/vmx-debug.o
>>>> CC [M]
>>>> /home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/kvm_main.o
>>>> CC [M] /home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/mmu.o
>>>> /home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/mmu.c:1152:
>>>> error:
>>>> expected '=', ',', ';', 'asm' or '__attribute__' before
>>>> 'last_updated_pte_accessed'
>>>> /home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/mmu.c: In
>>>> function
>>>> 'kvm_mmu_pte_write':
>>>> /home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/mmu.c:1180:
>>>> error:
>>>> implicit declaration of function 'last_updated_pte_accessed'
>>>> make[2]: ***
>>>> [/home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/mmu.o] Error 1
>>>> make[1]: ***
>>>> [_module_/home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel] Error 2
>>>> make[1]: Leaving directory `/usr/src/kernels/2.6.18-8.1.10.el5-x86_64'
>>>> make: *** [all] Error 2
>>>>
>>>>
>>> Try adding '#define bool _Bool' to kernel/external-module-compat.h, and
>>> let us know. I'll fix it for kvm-45.
>>>
>>
>> i just put after the #include <linux/smp.h> but it doesn't help.
>>
>>
>
> That should have worked. How about '#define bool int'?

with _Bool:
CC [M] /home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/vmx.o
/home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/vmx.c:39: error:
expected ')' before '&' token
/home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/vmx.c:39: error:
'param_set__Bool' undeclared here (not in a function)
/home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/vmx.c:39: error:
'param_get__Bool' undeclared here (not in a function)
with int it's working