Re: [RFC] KVM Source layout Proposal to accommodatenew CPU architecture

Zhang, Xiantao
2007-09-30T02:26:48Z

Rusty Russell wrote:
> On Thu, 2007-09-27 at 11:18 +0200, Avi Kivity wrote:
>> The whole drivers/kvm/ thing was just a trick to get merged quickly.
>> I think the new layout should be something like
>>
>> virt/kvm/, include/linux/kvm*.h -> common code
>> virt/lguest/ -> the other hypervisor
>> virt/virtio/ -> shared I/O infrastructure
>> virt/ -> the CONFIG_VIRTIALIZATION menu
>> arch/x86/kvm/, include/asm-x86/ -> x86 specific code
>> arch/ia64/kvm/, include/asm-ia64/ -> ia64 specific code
>
> The problem with this separation is that module source cannot span
> directories (at least, not that I could find).

Basically agree. That is also why we put all arch-specifica files in one
directory.
But if only one or two files is outside main directory, maybe Makefile
of module can
use relative position to locate them.

> This is why lguest went for "i386_" prefix for arch separation.
>
> Cheers,
> Rusty.