From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Vivier Subject: Re: [PATCH] Correct management of REP prefix Date: Wed, 03 Oct 2007 09:23:54 +0200 Message-ID: <4703438A.6010307@bull.net> References: <1190928863669-git-send-email-Laurent.Vivier@bull.net> <11912292661049-git-send-email-Laurent.Vivier@bull.net> <5461330FA59EDB46BE9AB8AAF2C431AD055A4295@scsmsx412.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1853329992==" Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org To: "Kamble, Nitin A" Return-path: In-Reply-To: <5461330FA59EDB46BE9AB8AAF2C431AD055A4295-1a9uaKK1+wJcIJlls4ac1rfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --===============1853329992== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig6FF6D6F40EE31AE83B277A8A" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig6FF6D6F40EE31AE83B277A8A Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Kamble, Nitin A wrote: > Hi Laurent, > This patch looks much cleaner to me.=20 >=20 > I see you are saving the regs like this in the patch. > memcpy(c->regs, ctxt->vcpu->regs, sizeof c->regs); >=20 > But I don't see any place in the patch these regs getting restored afte= r > failure. >=20 > Is it taken care of the code outside of the patch? In fact, during the emulation the function works on c->regs and copy them= into ctxt->vpcu->regs on success (see label "writeback"). The result is in vcp= u not in c->regs. If the function fails, as we didn't modify ctxt->vcpu->regs, we can re-st= art with original values by copying again ctxt->vcpu->regs to c->regs. Regargs, Laurent --=20 ------------- Laurent.Vivier-6ktuUTfB/bM@public.gmane.org -------------- "Software is hard" - Donald Knuth --------------enig6FF6D6F40EE31AE83B277A8A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.7 (GNU/Linux) iD8DBQFHA0OO9Kffa9pFVzwRAp1mAKCBuV0uJflpEO/cP3KUGZHqIG46gACfVtGF Tv6caZmvd0vkpKcnlX01UsA= =vKwb -----END PGP SIGNATURE----- --------------enig6FF6D6F40EE31AE83B277A8A-- --===============1853329992== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ --===============1853329992== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel --===============1853329992==--