Re: [PATCH 05/10] CodingStyle cleanup

[Anthony Liguori <aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>]

Mike Day wrote:
> Signed-off-by: Mike D. Day <ncmike-eyUYGtrA2zhAfugRpC6u6w@public.gmane.org>
> ---
>
>  	if (unlikely(vcpu->mp_state == VCPU_MP_STATE_SIPI_RECEIVED)) {
> -		printk("vcpu %d received sipi with vector # %x\n",
> +		printk(KERN_DEBUG "vcpu %d received sipi with vector # %x\n",
>  		       vcpu->vcpu_id, vcpu->sipi_vector);
>   

I think KERN_INFO would better fit the intention of these printk()s.  I 
don't really like the idea that a guest can trigger a printk() though.  
A printk() flood can potentially hide important information from the 
user and it chews disk space on /var/log.  I'm somewhat inclined to 
think that we should try to avoid these in general but if we do use 
them, I think we should limit them to only printing out once per-guest.

What do you think Avi?

Regards,

Anthony Liguori

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/