From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 05/10] CodingStyle cleanup Date: Fri, 05 Oct 2007 13:46:10 +0200 Message-ID: <47062402.1040001@qumranet.com> References: <20071003114234.GD1411@silverwood.ncultra.org> <4703B100.5020502@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Anthony Liguori Return-path: In-Reply-To: <4703B100.5020502-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Anthony Liguori wrote: > Mike Day wrote: > >> Signed-off-by: Mike D. Day >> --- >> >> if (unlikely(vcpu->mp_state == VCPU_MP_STATE_SIPI_RECEIVED)) { >> - printk("vcpu %d received sipi with vector # %x\n", >> + printk(KERN_DEBUG "vcpu %d received sipi with vector # %x\n", >> vcpu->vcpu_id, vcpu->sipi_vector); >> >> > > I think KERN_INFO would better fit the intention of these printk()s. I > don't really like the idea that a guest can trigger a printk() though. > A printk() flood can potentially hide important information from the > user and it chews disk space on /var/log. I'm somewhat inclined to > think that we should try to avoid these in general but if we do use > them, I think we should limit them to only printing out once per-guest. > > What do you think Avi? > This should probably be pr_debug() or something. -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/