From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH] [2/2] Split arch specific makefile code out
Date: Sun, 07 Oct 2007 13:50:54 +0200 [thread overview]
Message-ID: <4708C81E.8090701@qumranet.com> (raw)
In-Reply-To: <1191356738.15279.8.camel@laptop>
Jerone Young wrote:
> This patch makes things better for cross compiling. It also makes adding
> a new architecture to the current make system much easier.
>
> +CFLAGS += -I $(KERNELDIR)/include $(autodepend-flags) -g -fomit-frame-pointer \
> + -Wall
> +CFLAGS += -m32
> +CFLAGS += -m64
>
Nowhere is CFLAGS defined, that I can see. This means that a stray
CFLAGS environment variable will affect the build (this is the cause of
my dislike to ?= as well).
Please change so that make variables cannot be affected by the environment.
--
Any sufficiently difficult bug is indistinguishable from a feature.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-10-07 11:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-02 20:25 [PATCH] [2/2] Split arch specific makefile code out Jerone Young
2007-10-07 11:50 ` Avi Kivity [this message]
[not found] ` <4708C81E.8090701-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-10-08 2:03 ` Jerone Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4708C81E.8090701@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox