From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] [2/2] Split arch specific makefile code out Date: Sun, 07 Oct 2007 13:50:54 +0200 Message-ID: <4708C81E.8090701@qumranet.com> References: <1191356738.15279.8.camel@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org Return-path: In-Reply-To: <1191356738.15279.8.camel@laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Jerone Young wrote: > This patch makes things better for cross compiling. It also makes adding > a new architecture to the current make system much easier. > > +CFLAGS += -I $(KERNELDIR)/include $(autodepend-flags) -g -fomit-frame-pointer \ > + -Wall > +CFLAGS += -m32 > +CFLAGS += -m64 > Nowhere is CFLAGS defined, that I can see. This means that a stray CFLAGS environment variable will affect the build (this is the cause of my dislike to ?= as well). Please change so that make variables cannot be affected by the environment. -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/