From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/3] kvm_free_lapic() to pair with kvm_create_lapic() Date: Mon, 08 Oct 2007 10:08:13 +0200 Message-ID: <4709E56D.9060202@qumranet.com> References: <200710081048.30985.rusty@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Rusty Russell Return-path: In-Reply-To: <200710081048.30985.rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Rusty Russell wrote: > Instead of the asymetry of kvm_free_apic, implement kvm_free_lapic(). > And guess what? I found a minor bug: we don't need to hrtimer_cancel() > from kvm_main.c, because we do that in kvm_free_apic(). > > Also: > 1) kvm_vcpu_uninit should be the reverse order from kvm_vcpu_init. > 2) Don't set apic->regs_page to zero before freeing apic. > > Applied all three, thanks. -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/