public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: "Dong, Eddie" <eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: split ioapic reset API
Date: Mon, 08 Oct 2007 12:30:27 +0200	[thread overview]
Message-ID: <470A06C3.1050506@qumranet.com> (raw)
In-Reply-To: <10EA09EFD8728347A513008B6B0DA77A0231BB33-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>

Dong, Eddie wrote:
> This one is a preparation for kernel devices reset support.
>
>
>
>        Split ioapic reset API and export PIC reset API
>   

Please split into two patches, I need to fold them into the pic patch
and the ioapic patch.

>  
> -static void pic_reset(void *opaque)
> +void kvm_pic_reset(void *opaque)
>  {
>  	struct kvm_kpic_state *s = opaque;
>   


Does this really need to be an opaque?  Or is this some qemu remnant?

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

  parent reply	other threads:[~2007-10-08 10:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-08 10:16 split ioapic reset API Dong, Eddie
     [not found] ` <10EA09EFD8728347A513008B6B0DA77A0231BB33-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-10-08 10:30   ` Avi Kivity [this message]
     [not found]     ` <470A06C3.1050506-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-10-10  6:12       ` Dong, Eddie
     [not found]         ` <10EA09EFD8728347A513008B6B0DA77A02364239-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-10-10 10:15           ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=470A06C3.1050506@qumranet.com \
    --to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox