From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: split ioapic reset API Date: Mon, 08 Oct 2007 12:30:27 +0200 Message-ID: <470A06C3.1050506@qumranet.com> References: <10EA09EFD8728347A513008B6B0DA77A0231BB33@pdsmsx411.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: "Dong, Eddie" Return-path: In-Reply-To: <10EA09EFD8728347A513008B6B0DA77A0231BB33-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Dong, Eddie wrote: > This one is a preparation for kernel devices reset support. > > > > Split ioapic reset API and export PIC reset API > Please split into two patches, I need to fold them into the pic patch and the ioapic patch. > > -static void pic_reset(void *opaque) > +void kvm_pic_reset(void *opaque) > { > struct kvm_kpic_state *s = opaque; > Does this really need to be an opaque? Or is this some qemu remnant? -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/