[PATCH] Allow users to override compiler checks for gcc3 by only using --disable-gcc-check as done in qemu

[PATCH] Allow users to override compiler checks for gcc3 by only using --disable-gcc-check as done in qemu

[Carlo Marcelo Arenas Belon]

Allow users to override the compiler checks for gcc3 that are required for
compatibility with qemu in the same way that qemu does.

If the qemu-cc option is not used but disable-gcc-check is requested then
assume that the default system gcc should be used (chosen by name)

This patch fixes sourceforge bug id 1807620

Signed-off-by: Carlo Marcelo Arenas Belon <carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org>
---
 configure |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index d9292fe..33a56d2 100755
--- a/configure
+++ b/configure
@@ -63,8 +63,12 @@ while [[ "$1" = -* ]]; do
 done
 
 if [[ -z "$qemu_cc" ]]; then
-    echo "$0: cannot locate gcc 3.x. please install it or specify with --qemu-cc"
-    exit 1
+    if [[ -z "$disable_gcc_check" ]]; then
+        echo "$0: cannot locate gcc 3.x. please install it or specify with --qemu-cc"
+        exit 1
+    else
+        qemu_cc=gcc
+    fi
 fi
 
 libkvm_kerneldir="$kerneldir"
-- 
1.5.2.5


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: [PATCH] Allow users to override compiler checks for gcc3 by only using --disable-gcc-check as done in qemu

[Avi Kivity]

Carlo Marcelo Arenas Belon wrote:
> Allow users to override the compiler checks for gcc3 that are required for
> compatibility with qemu in the same way that qemu does.
>
> If the qemu-cc option is not used but disable-gcc-check is requested then
> assume that the default system gcc should be used (chosen by name)
>
> This patch fixes sourceforge bug id 1807620
>
>   

This deviates from normal qemu, no?  I think qemu-s --disable-gcc-check
doesn't imply anything about the compiler.



-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: [PATCH] Allow users to override compiler checks for gcc3 by only using --disable-gcc-check as done in qemu

[Carlo Marcelo Arenas Belon]

On Mon, Oct 08, 2007 at 06:23:30PM +0200, Avi Kivity wrote:
> Carlo Marcelo Arenas Belon wrote:
> >
> > If the qemu-cc option is not used but disable-gcc-check is requested then
> > assume that the default system gcc should be used (chosen by name)
> >
> > This patch fixes sourceforge bug id 1807620
> 
> This deviates from normal qemu, no?  I think qemu-s --disable-gcc-check
> doesn't imply anything about the compiler.

--disable-gcc-check in qemu's configure just shortcuts all the tests to
validate that the compiler to be used is gcc-3.x and that defaults to "gcc"

in the case of kvm's configure, using "gcc" as the default compiler will be
the case if :

1) the user didn't provide his own --qemu-cc preference
2) gcc-3.x couldn't be found when searching by name in /usr/bin/

and which is the expected behavior on qemu when --disable-gcc-check is used.

Carlo

PS. ideally host_cc should be by default "${CC}" if defined but using "gcc" is
what qemu's configure does so did the same for consistency reasons

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/