Should we show vcpu_id info when an unknown exception happens?

Should we show vcpu_id info when an unknown exception happens?

[Dong, Eddie]

[-- Attachment #1: Type: text/plain, Size: 1143 bytes --]



commit e634910140a7e8a55322cd6a1d94fcfd77d9eae0
Author: root <root@vt32-pae.(none)>
Date:   Mon Oct 8 16:52:01 2007 +0800

    show vcpu_id in case of unknown hw exception.
    
    Signed-off-by: Yaozu (Eddie) Dong <eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

diff --git a/user/kvmctl.c b/user/kvmctl.c
index 3dee407..eeddb54 100644
--- a/user/kvmctl.c
+++ b/user/kvmctl.c
@@ -1053,8 +1053,8 @@ again:
 	if (1) {
 		switch (run->exit_reason) {
 		case KVM_EXIT_UNKNOWN:
-			fprintf(stderr, "unhandled vm exit:  0x%x\n", 
-				(unsigned)run->hw.hardware_exit_reason);
+			fprintf(stderr, "unhandled vm exit: 0x%x
vcpu_id=%d\n", 
+				(unsigned)run->hw.hardware_exit_reason,
vcpu);
 			kvm_show_regs(kvm, vcpu);
 			abort();
 			break;
@@ -1131,8 +1131,8 @@ again:
 	if (1) {
 		switch (run->exit_reason) {
 		case KVM_EXIT_UNKNOWN:
-			fprintf(stderr, "unhandled vm exit:  0x%x\n", 
-				(unsigned)run->hw.hardware_exit_reason);
+			fprintf(stderr, "unhandled vm exit: 0x%x
vcpu_id=%d\n", 
+
(unsigned)run->hw.hardware_exit_reason,vcpu);
 			kvm_show_regs(kvm, vcpu);
 			abort();
 			break;

[-- Attachment #2: reset-u0.patch --]
[-- Type: application/octet-stream, Size: 1074 bytes --]

commit e634910140a7e8a55322cd6a1d94fcfd77d9eae0
Author: root <root@vt32-pae.(none)>
Date:   Mon Oct 8 16:52:01 2007 +0800

    show vcpu_id in case of unknown hw exception.
    
    Signed-off-by: Yaozu (Eddie) Dong <eddie.dong@intel.com>

diff --git a/user/kvmctl.c b/user/kvmctl.c
index 3dee407..eeddb54 100644
--- a/user/kvmctl.c
+++ b/user/kvmctl.c
@@ -1053,8 +1053,8 @@ again:
 	if (1) {
 		switch (run->exit_reason) {
 		case KVM_EXIT_UNKNOWN:
-			fprintf(stderr, "unhandled vm exit:  0x%x\n", 
-				(unsigned)run->hw.hardware_exit_reason);
+			fprintf(stderr, "unhandled vm exit: 0x%x vcpu_id=%d\n", 
+				(unsigned)run->hw.hardware_exit_reason, vcpu);
 			kvm_show_regs(kvm, vcpu);
 			abort();
 			break;
@@ -1131,8 +1131,8 @@ again:
 	if (1) {
 		switch (run->exit_reason) {
 		case KVM_EXIT_UNKNOWN:
-			fprintf(stderr, "unhandled vm exit:  0x%x\n", 
-				(unsigned)run->hw.hardware_exit_reason);
+			fprintf(stderr, "unhandled vm exit: 0x%x vcpu_id=%d\n", 
+				(unsigned)run->hw.hardware_exit_reason,vcpu);
 			kvm_show_regs(kvm, vcpu);
 			abort();
 			break;

[-- Attachment #3: Type: text/plain, Size: 314 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

[-- Attachment #4: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: Should we show vcpu_id info when an unknown exception happens?

[Avi Kivity]

Dong, Eddie wrote:
> commit e634910140a7e8a55322cd6a1d94fcfd77d9eae0
> Author: root <root@vt32-pae.(none)>
> Date:   Mon Oct 8 16:52:01 2007 +0800
>
>     show vcpu_id in case of unknown hw exception.
>     
>   

Applied, thanks.


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/