Re: [patch] kvmctl.c: allow custom memory setup.

Avi Kivity
2007-10-18T10:39:36Z

Izik Eidus wrote:
> On Thu, 2007-10-18 at 12:18 +0200, Gerd Hoffmann wrote:
>
>> Dor Laor wrote:
>>
>>> Gerd Hoffmann wrote:
>>>
>>>> I don't see how I can pass a pointer to kvm_create_userspace_memory()
>>>> via kvm_create() without breaking the libkvm interface. There is no
>>>> flags field or similar which could be used to signal "vm_mem is a valid
>>>> pointer, please use that instead of mmap()'ing anonymous memory".
>>>>
>>> There is no need to keep binary compat to libkvm as long as it is linked
>>> statically.
>>>
>> What about source compatibility?
>>
>> cheers,
>> Gerd
>>
>>
>>
> anyone who use kvmctl, should not call kvm_create_userspace_memory
> directly,
>
> instead should call kvm_create()...
>
>

Why not have an API for creating memory slots? It allows much more
flexibility and is more in line with what qemu wants.

--
error compiling committee.c: too many arguments to function