From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: kvm-45 problems Date: Wed, 10 Oct 2007 12:58:18 +0200 Message-ID: <470CB04A.2010303@qumranet.com> References: <47065A1A.9070607@bppiac.hu><10EA09EFD8728347A513008B6B0DA77A014E8AFF@pdsmsx411.ccr.corp.intel.com> <470B2381.7080302@bppiac.hu> <10EA09EFD8728347A513008B6B0DA77A02125F53@pdsmsx411.ccr.corp.intel.com> <470B4ED5.4060607@qumranet.com> <470B557A.9030602@qumranet.com> <10EA09EFD8728347A513008B6B0DA77A02125F5A@pdsmsx411.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------070805020504040304060205" Cc: kvm-devel To: "Zhao, Yunfeng" Return-path: In-Reply-To: <10EA09EFD8728347A513008B6B0DA77A02125F5A-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org This is a multi-part message in MIME format. --------------070805020504040304060205 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Zhao, Yunfeng wrote: > This fix cannot resolve this issue. > Against latest kvm commits, SMP linux with 4 vcpus still cannot boot up. > But the issue will not happen , if adding "-smp4 -no-acpi". > Can you try the attached patch? -- error compiling committee.c: too many arguments to function --------------070805020504040304060205 Content-Type: text/x-patch; name="remote-flush-test.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="remote-flush-test.patch" diff --git a/kernel/kvm_main.c b/kernel/kvm_main.c index 0b2894a..61d931e 100644 --- a/kernel/kvm_main.c +++ b/kernel/kvm_main.c @@ -235,11 +235,7 @@ void kvm_flush_remote_tlbs(struct kvm *kvm) * to complete. */ for (cpu = first_cpu(cpus); cpu != NR_CPUS; cpu = next_cpu(cpu, cpus)) - smp_call_function_single(cpu, ack_flush, &completed, 1, 0); - while (atomic_read(&completed) != needed) { - cpu_relax(); - barrier(); - } + smp_call_function_single(cpu, ack_flush, &completed, 1, 1); } int kvm_vcpu_init(struct kvm_vcpu *vcpu, struct kvm *kvm, unsigned id) --------------070805020504040304060205 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ --------------070805020504040304060205 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel --------------070805020504040304060205--