From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Vivier Subject: Re: kvm-45 problems Date: Wed, 10 Oct 2007 13:23:11 +0200 Message-ID: <470CB61F.9040209@bull.net> References: <47065A1A.9070607@bppiac.hu><10EA09EFD8728347A513008B6B0DA77A014E8AFF@pdsmsx411.ccr.corp.intel.com> <470B2381.7080302@bppiac.hu> <10EA09EFD8728347A513008B6B0DA77A02125F53@pdsmsx411.ccr.corp.intel.com> <470B4ED5.4060607@qumranet.com> <470B557A.9030602@qumranet.com> <10EA09EFD8728347A513008B6B0DA77A02125F5A@pdsmsx411.ccr.corp.intel.com> <470CB04A.2010303@qumranet.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1309576971==" Cc: kvm-devel To: Avi Kivity Return-path: In-Reply-To: <470CB04A.2010303-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --===============1309576971== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig9A8783523898BB6B4FB560F5" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig9A8783523898BB6B4FB560F5 Content-Type: multipart/mixed; boundary="------------020507010900060107000005" This is a multi-part message in MIME format. --------------020507010900060107000005 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > Zhao, Yunfeng wrote: >> This fix cannot resolve this issue. >> Against latest kvm commits, SMP linux with 4 vcpus still cannot boot u= p. >> But the issue will not happen , if adding "-smp4 -no-acpi". >> =20 >=20 > Can you try the attached patch? >=20 >=20 >=20 >=20 >=20 >=20 > -----------------------------------------------------------------------= - >=20 > diff --git a/kernel/kvm_main.c b/kernel/kvm_main.c > index 0b2894a..61d931e 100644 > --- a/kernel/kvm_main.c > +++ b/kernel/kvm_main.c > @@ -235,11 +235,7 @@ void kvm_flush_remote_tlbs(struct kvm *kvm) > * to complete. > */ > for (cpu =3D first_cpu(cpus); cpu !=3D NR_CPUS; cpu =3D next_cpu(cpu,= cpus)) > - smp_call_function_single(cpu, ack_flush, &completed, 1, 0); > - while (atomic_read(&completed) !=3D needed) { > - cpu_relax(); > - barrier(); > - } > + smp_call_function_single(cpu, ack_flush, &completed, 1, 1); > } > =20 > int kvm_vcpu_init(struct kvm_vcpu *vcpu, struct kvm *kvm, unsigned id)= This part will be obsolete as soon as linux will export smp_call_function_mask(). This is already in mm tree: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/= 2.6.23-rc8-mm2/broken-out/x86_64-mm-export-i386-smp_call_function_mask-to= -modules.patch ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/= 2.6.23-rc8-mm2/broken-out/x86_64-mm-implement-missing-x86_64-function-smp= _call_function_mask.patch Apply these patches and try the attached patch for KVM. Laurent --=20 ---------------- Laurent.Vivier-6ktuUTfB/bM@public.gmane.org ----------------- "Given enough eyeballs, all bugs are shallow" E. S. Raymond --------------020507010900060107000005 Content-Type: text/plain; name="smp_call_function_mask-kvm" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="smp_call_function_mask-kvm" SW5kZXg6IGt2bS9kcml2ZXJzL2t2bS9rdm1fbWFpbi5jCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGt2 bS5vcmlnL2RyaXZlcnMva3ZtL2t2bV9tYWluLmMJMjAwNy0wOS0xMiAxNzo0OTo1MS4wMDAw MDAwMDAgKzAyMDAKKysrIGt2bS9kcml2ZXJzL2t2bS9rdm1fbWFpbi5jCTIwMDctMDktMTIg MTc6NTg6MTguMDAwMDAwMDAwICswMjAwCkBAIC0xOTgsMjEgKzE5OCwxNSBAQCBzdGF0aWMg dm9pZCB2Y3B1X3B1dChzdHJ1Y3Qga3ZtX3ZjcHUgKnZjCiAKIHN0YXRpYyB2b2lkIGFja19m bHVzaCh2b2lkICpfY29tcGxldGVkKQogewotCWF0b21pY190ICpjb21wbGV0ZWQgPSBfY29t cGxldGVkOwotCi0JYXRvbWljX2luYyhjb21wbGV0ZWQpOwogfQogCiB2b2lkIGt2bV9mbHVz aF9yZW1vdGVfdGxicyhzdHJ1Y3Qga3ZtICprdm0pCiB7Ci0JaW50IGksIGNwdSwgbmVlZGVk OworCWludCBpLCBjcHU7CiAJY3B1bWFza190IGNwdXM7CiAJc3RydWN0IGt2bV92Y3B1ICp2 Y3B1OwotCWF0b21pY190IGNvbXBsZXRlZDsKIAotCWF0b21pY19zZXQoJmNvbXBsZXRlZCwg MCk7CiAJY3B1c19jbGVhcihjcHVzKTsKLQluZWVkZWQgPSAwOwogCWZvciAoaSA9IDA7IGkg PCBLVk1fTUFYX1ZDUFVTOyArK2kpIHsKIAkJdmNwdSA9IGt2bS0+dmNwdXNbaV07CiAJCWlm ICghdmNwdSkKQEAgLTIyMSwyMyArMjE1LDkgQEAgdm9pZCBrdm1fZmx1c2hfcmVtb3RlX3Rs YnMoc3RydWN0IGt2bSAqawogCQkJY29udGludWU7CiAJCWNwdSA9IHZjcHUtPmNwdTsKIAkJ aWYgKGNwdSAhPSAtMSAmJiBjcHUgIT0gcmF3X3NtcF9wcm9jZXNzb3JfaWQoKSkKLQkJCWlm ICghY3B1X2lzc2V0KGNwdSwgY3B1cykpIHsKLQkJCQljcHVfc2V0KGNwdSwgY3B1cyk7Ci0J CQkJKytuZWVkZWQ7Ci0JCQl9Ci0JfQotCi0JLyoKLQkgKiBXZSByZWFsbHkgd2FudCBzbXBf Y2FsbF9mdW5jdGlvbl9tYXNrKCkgaGVyZS4gIEJ1dCB0aGF0J3Mgbm90Ci0JICogYXZhaWxh YmxlLCBzbyBpcGkgYWxsIGNwdXMgaW4gcGFyYWxsZWwgYW5kIHdhaXQgZm9yIHRoZW0KLQkg KiB0byBjb21wbGV0ZS4KLQkgKi8KLQlmb3IgKGNwdSA9IGZpcnN0X2NwdShjcHVzKTsgY3B1 ICE9IE5SX0NQVVM7IGNwdSA9IG5leHRfY3B1KGNwdSwgY3B1cykpCi0JCXNtcF9jYWxsX2Z1 bmN0aW9uX3NpbmdsZShjcHUsIGFja19mbHVzaCwgJmNvbXBsZXRlZCwgMSwgMCk7Ci0Jd2hp bGUgKGF0b21pY19yZWFkKCZjb21wbGV0ZWQpICE9IG5lZWRlZCkgewotCQljcHVfcmVsYXgo KTsKLQkJYmFycmllcigpOworCQkJY3B1X3NldChjcHUsIGNwdXMpOwogCX0KKwlzbXBfY2Fs bF9mdW5jdGlvbl9tYXNrKGNwdXMsIGFja19mbHVzaCwgTlVMTCwgMSk7CiB9CiAKIGludCBr dm1fdmNwdV9pbml0KHN0cnVjdCBrdm1fdmNwdSAqdmNwdSwgc3RydWN0IGt2bSAqa3ZtLCB1 bnNpZ25lZCBpZCkK --------------020507010900060107000005-- --------------enig9A8783523898BB6B4FB560F5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.7 (GNU/Linux) iD8DBQFHDLYi9Kffa9pFVzwRAgo9AJsGR+UJ/U281vBM5a4Nc8/kq2zAvACgziNJ Zc8/D7eZMQK/e6Si10FGX/0= =w2V2 -----END PGP SIGNATURE----- --------------enig9A8783523898BB6B4FB560F5-- --===============1309576971== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ --===============1309576971== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel --===============1309576971==--