From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Use a table to dispatch IO requests in kvmctl Date: Wed, 10 Oct 2007 15:47:22 +0200 Message-ID: <470CD7EA.3040500@qumranet.com> References: <11919660094186-git-send-email-aliguori@us.ibm.com> <470C7BDC.7020106@qumranet.com> <470CD298.8060704@us.ibm.com> <470CD2CD.5090903@qumranet.com> <470CD6D3.8080805@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Jerone Young , Hollis Blanchard To: Anthony Liguori Return-path: In-Reply-To: <470CD6D3.8080805-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Anthony Liguori wrote: >> >>> >>> QEMU uses an array for PIO but a table for MMIO. I figured it would >>> be best to just use the same table. >> >> Or the same array? > > Indexed by the address or just sorted and searchable? MMIO addresses > are rather sparse so the former seems like the only sane thing. I'm betting that a plain unsorted array will beat anything else with less than 50 entries. Also that the difference will be swamped by vmexit costs and by the actual emulation costs. > It also has to support subpage granularity. My patent pending unsorted array supports that out of the box. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/