From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: RFC/patch portability: split kvm_vcpu_ioctl v1 Date: Thu, 11 Oct 2007 19:30:32 +0200 Message-ID: <470E5DB8.9060706@qumranet.com> References: <1192123012.5885.13.camel@cotte.boeblingen.de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" To: Carsten Otte Return-path: In-Reply-To: <1192123012.5885.13.camel-WIxn4w2hgUz3YA32ykw5MLlKpX0K8NHHQQ4Iyu8u01E@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Carsten Otte wrote: > This patch splits kvm_vcpu_ioctl into archtecture independent parts, and > x86 specific parts which go to kvm_arch_vcpu_ioctl in x86.c. > > Common ioctls for all architectures are: > KVM_RUN, KVM_GET/SET_(S-)REGS, KVM_TRANSLATE, KVM_INTERRUPT, > KVM_DEBUG_GUEST, KVM_SET_SIGNAL_MASK, KVM_GET/SET_FPU > Note that some PPC chips don't have an FPU, so we might need an #ifdef > around KVM_GET/SET_FPU one day. > > x86 specific ioctls are: > KVM_GET/SET_LAPIC, KVM_SET_CPUID, KVM_GET/SET_MSRS > > An interresting aspect is vcpu_load/vcpu_put. We now have a common > kvm_vcpu_load/put which does the preemption stuff, and an architecture > specific kvm_arch_vcpu_load/put. In the x86 case, this one calls the > vmx/svm function defined in kvm_x86_ops. > Applied, thanks. I renamed kvm_vcpu_load() and kvm_vcpu_put() back to vcpu_load() and vcpu_put() in order to keep the patch small and simple, and because I'm emotionally attached to the original names. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/