Re: RFC/patch portability: split kvm_vcpu_ioctl v1

Carsten Otte
2007-10-11T20:16:17Z

Avi Kivity wrote:
> This is wrong -- kvm_main.c calls vmalloc() so this is needed. The fact
> that it is included by something else doesn't mean we can remove it; we
> don't want to depend on random #includes within header files.
>
> Only remove a #include if nothing within the including file depends on it.
You're right, the include needs to stay in. I should've seen that.
I'll doublecheck next time I remove an #include.