Re: RFC/patch portability: split kvm_vcpu_ioctl v1

Avi Kivity
2007-10-11T17:30:32Z

> This patch splits kvm_vcpu_ioctl into archtecture independent parts, and
> x86 specific parts which go to kvm_arch_vcpu_ioctl in x86.c.
>
> Common ioctls for all architectures are:
> KVM_RUN, KVM_GET/SET_(S-)REGS, KVM_TRANSLATE, KVM_INTERRUPT,
> KVM_DEBUG_GUEST, KVM_SET_SIGNAL_MASK, KVM_GET/SET_FPU
> Note that some PPC chips don't have an FPU, so we might need an #ifdef
> around KVM_GET/SET_FPU one day.
>
> x86 specific ioctls are:
> KVM_GET/SET_LAPIC, KVM_SET_CPUID, KVM_GET/SET_MSRS
>
> An interresting aspect is vcpu_load/vcpu_put. We now have a common
> kvm_vcpu_load/put which does the preemption stuff, and an architecture
> specific kvm_arch_vcpu_load/put. In the x86 case, this one calls the
> vmx/svm function defined in kvm_x86_ops.
>

Applied, thanks. I renamed kvm_vcpu_load() and kvm_vcpu_put() back to
vcpu_load() and vcpu_put() in order to keep the patch small and simple,
and because I'm emotionally attached to the original names.

--
error compiling committee.c: too many arguments to function