Re: RFC/patch portability: split kvm_vcpu_ioctl v1

Carsten Otte
2007-10-11T20:15:12Z

Avi Kivity wrote:
> Applied, thanks. I renamed kvm_vcpu_load() and kvm_vcpu_put() back to
> vcpu_load() and vcpu_put() in order to keep the patch small and simple,
> and because I'm emotionally attached to the original names.
Oh, I think I had a very good reason for renaming it: it's no longer
static, and thus part of the kernel's global namespace in case kvm is
built-in. As far as I know, modules are expected to prefix any symbol
they use with their module name.
I am sorry for the emotional part of it, I tend to stick to old names
too once I got used to them.
In case you decide you want kvm_vcpu_load/put again, let me know so
that I can supply a patch on top of git that renames it.