From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: RFC/patch portability: split kvm_vcpu_ioctl v1 Date: Thu, 11 Oct 2007 19:47:38 +0200 Message-ID: <470E61BA.6090404@qumranet.com> References: <1192123012.5885.13.camel@cotte.boeblingen.de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" To: Carsten Otte Return-path: In-Reply-To: <1192123012.5885.13.camel-WIxn4w2hgUz3YA32ykw5MLlKpX0K8NHHQQ4Iyu8u01E@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Carsten Otte wrote: > This patch splits kvm_vcpu_ioctl into archtecture independent parts, and > x86 specific parts which go to kvm_arch_vcpu_ioctl in x86.c. > > > static inline int kvm_mmu_page_fault(struct kvm_vcpu *vcpu, gva_t gva, > Index: kvm/drivers/kvm/kvm_main.c > =================================================================== > --- kvm.orig/drivers/kvm/kvm_main.c 2007-10-11 15:41:33.000000000 +0200 > +++ kvm/drivers/kvm/kvm_main.c 2007-10-11 19:03:18.000000000 +0200 > @@ -28,7 +28,6 @@ > #include > #include > #include > -#include > #include > #include > #include > This is wrong -- kvm_main.c calls vmalloc() so this is needed. The fact that it is included by something else doesn't mean we can remove it; we don't want to depend on random #includes within header files. Only remove a #include if nothing within the including file depends on it. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/