public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Carsten Otte <cotte-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
To: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: "kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
	<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: RFC/patch portability: split kvm_vcpu_ioctl v1
Date: Thu, 11 Oct 2007 22:15:12 +0200	[thread overview]
Message-ID: <470E8450.4070303@de.ibm.com> (raw)
In-Reply-To: <470E5DB8.9060706-atKUWr5tajBWk0Htik3J/w@public.gmane.org>

Avi Kivity wrote:
> Applied, thanks.  I renamed kvm_vcpu_load() and kvm_vcpu_put() back to 
> vcpu_load() and vcpu_put() in order to keep the patch small and simple, 
> and because I'm emotionally attached to the original names.
Oh, I think I had a very good reason for renaming it: it's no longer 
static, and thus part of the kernel's global namespace in case kvm is 
built-in. As far as I know, modules are expected to prefix any symbol 
they use with their module name.
I am sorry for the emotional part of it, I tend to stick to old names 
too once I got used to them.
In case you decide you want kvm_vcpu_load/put again, let me know so 
that I can supply a patch on top of git that renames it.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

  parent reply	other threads:[~2007-10-11 20:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-11 17:16 RFC/patch portability: split kvm_vcpu_ioctl v1 Carsten Otte
     [not found] ` <1192123012.5885.13.camel-WIxn4w2hgUz3YA32ykw5MLlKpX0K8NHHQQ4Iyu8u01E@public.gmane.org>
2007-10-11 17:30   ` Avi Kivity
     [not found]     ` <470E5DB8.9060706-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-10-11 20:15       ` Carsten Otte [this message]
     [not found]         ` <470E8450.4070303-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-10-12  6:26           ` Avi Kivity
     [not found]             ` <470F137B.1040805-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-10-12  8:23               ` Carsten Otte
     [not found]                 ` <470F2EE9.3060503-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-10-13  8:08                   ` Avi Kivity
2007-10-11 17:47   ` Avi Kivity
     [not found]     ` <470E61BA.6090404-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-10-11 20:16       ` Carsten Otte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=470E8450.4070303@de.ibm.com \
    --to=cotte-ta70fqpds9bqt0dzr+alfa@public.gmane.org \
    --cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
    --cc=carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox