From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Otte Subject: Re: RFC/patch portability: split kvm_vcpu_ioctl v1 Date: Thu, 11 Oct 2007 22:16:17 +0200 Message-ID: <470E8491.8080908@de.ibm.com> References: <1192123012.5885.13.camel@cotte.boeblingen.de.ibm.com> <470E61BA.6090404@qumranet.com> Reply-To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" To: Avi Kivity Return-path: In-Reply-To: <470E61BA.6090404-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Avi Kivity wrote: > This is wrong -- kvm_main.c calls vmalloc() so this is needed. The fact > that it is included by something else doesn't mean we can remove it; we > don't want to depend on random #includes within header files. > > Only remove a #include if nothing within the including file depends on it. You're right, the include needs to stay in. I should've seen that. I'll doublecheck next time I remove an #include. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/