From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: RFC/patch portability: split kvm_vcpu_ioctl v1 Date: Fri, 12 Oct 2007 08:26:03 +0200 Message-ID: <470F137B.1040805@qumranet.com> References: <1192123012.5885.13.camel@cotte.boeblingen.de.ibm.com> <470E5DB8.9060706@qumranet.com> <470E8450.4070303@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org Return-path: In-Reply-To: <470E8450.4070303-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Carsten Otte wrote: > Avi Kivity wrote: >> Applied, thanks. I renamed kvm_vcpu_load() and kvm_vcpu_put() back >> to vcpu_load() and vcpu_put() in order to keep the patch small and >> simple, and because I'm emotionally attached to the original names. > Oh, I think I had a very good reason for renaming it: it's no longer > static, and thus part of the kernel's global namespace in case kvm is > built-in. As far as I know, modules are expected to prefix any symbol > they use with their module name. > I am sorry for the emotional part of it, I tend to stick to old names > too once I got used to them. > In case you decide you want kvm_vcpu_load/put again, let me know so > that I can supply a patch on top of git that renames it. I agree 100%, I'm just using the "keep the patch dead simple" excuse to delay the change. We can have a 'add kvm_ prefix' patch round later. Let's complete the separation first. There are some bigger offenders too, like set_crX(), which don't even start with the magic V and are exported to modules. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/