Re: [PATCH][Resend] Split kvm_vcpu to support new archs.

[Carsten Otte <cotte-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>]

Zhang, Xiantao wrote:
> diff --git a/drivers/kvm/ioapic.c b/drivers/kvm/ioapic.c
> index 3b69541..df67292 100644
> --- a/drivers/kvm/ioapic.c
> +++ b/drivers/kvm/ioapic.c
> @@ -156,7 +156,7 @@ static u32 ioapic_get_delivery_bitmask(struct
> kvm_ioapic *ioapic, u8 dest,
>  	if (dest_mode == 0) {	/* Physical mode. */
>  		if (dest == 0xFF) {	/* Broadcast. */
>  			for (i = 0; i < KVM_MAX_VCPUS; ++i)
> -				if (kvm->vcpus[i] &&
> kvm->vcpus[i]->apic)
> +				if (kvm->vcpus[i] &&
> kvm->vcpus[i]->arch.apic)
>  					mask |= 1 << i;
>  			return mask;
>  		}
Your mail client still wraps here, the patch is not applicable.

>  struct kvm_vcpu {
>  	struct kvm *kvm;
>  	struct preempt_notifier preempt_notifier;
>  	int vcpu_id;
>  	struct mutex mutex;
>  	int   cpu;
> -	u64 host_tsc;
>  	struct kvm_run *run;
>  	int interrupt_window_open;
This one should go to arch.
>  	int guest_mode;
>  	unsigned long requests;
>  	unsigned long irq_summary; /* bit vector: 1 per word in
> irq_pending */
>  	DECLARE_BITMAP(irq_pending, KVM_NR_INTERRUPTS);
Both irq related ones too please.

>  	int mmio_needed;
>  	int mmio_read_completed;
Not all architectures have mmio, please put this into arch specific part.

Other then that, the patch looks fine to me.



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/