From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Otte Subject: Re: [PATCH][Resend] Split kvm_vcpu to support new archs. Date: Fri, 12 Oct 2007 16:09:41 +0200 Message-ID: <470F8025.6060001@de.ibm.com> References: <42DFA526FC41B1429CE7279EF83C6BDC808D7E@pdsmsx415.ccr.corp.intel.com> Reply-To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, carsteno-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, Avi Kivity To: "Zhang, Xiantao" Return-path: In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC808D7E-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Zhang, Xiantao wrote: > diff --git a/drivers/kvm/ioapic.c b/drivers/kvm/ioapic.c > index 3b69541..df67292 100644 > --- a/drivers/kvm/ioapic.c > +++ b/drivers/kvm/ioapic.c > @@ -156,7 +156,7 @@ static u32 ioapic_get_delivery_bitmask(struct > kvm_ioapic *ioapic, u8 dest, > if (dest_mode == 0) { /* Physical mode. */ > if (dest == 0xFF) { /* Broadcast. */ > for (i = 0; i < KVM_MAX_VCPUS; ++i) > - if (kvm->vcpus[i] && > kvm->vcpus[i]->apic) > + if (kvm->vcpus[i] && > kvm->vcpus[i]->arch.apic) > mask |= 1 << i; > return mask; > } Your mail client still wraps here, the patch is not applicable. > struct kvm_vcpu { > struct kvm *kvm; > struct preempt_notifier preempt_notifier; > int vcpu_id; > struct mutex mutex; > int cpu; > - u64 host_tsc; > struct kvm_run *run; > int interrupt_window_open; This one should go to arch. > int guest_mode; > unsigned long requests; > unsigned long irq_summary; /* bit vector: 1 per word in > irq_pending */ > DECLARE_BITMAP(irq_pending, KVM_NR_INTERRUPTS); Both irq related ones too please. > int mmio_needed; > int mmio_read_completed; Not all architectures have mmio, please put this into arch specific part. Other then that, the patch looks fine to me. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/