From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
Subject: Re: [RFC] Paravirt timer for KVM
Date: Fri, 12 Oct 2007 13:58:48 -0500
Message-ID: <470FC3E8.6090006@codemonkey.ws>
References: <5d6222a80710120908s6b1f5845head84e7b7a463cd1@mail.gmail.com>
	<470FBF58.2080701@goop.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Jeremy Fitzhardinge <jeremy-TSDbQ3PG+2Y@public.gmane.org>
Return-path: <kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
In-Reply-To: <470FBF58.2080701-TSDbQ3PG+2Y@public.gmane.org>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
List-Help: <mailto:kvm-devel-request-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org?subject=subscribe>
Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
List-Id: kvm.vger.kernel.org

Jeremy Fitzhardinge wrote:
> Glauber de Oliveira Costa wrote:
>   
>> My next TODOs with it are:
>> * Get SMP working
>> * Try something for stolen time, as jeremy's last suggestion for anthony's patch
>> * Measure the time it takes for a hypercall, and subtract this time
>> for calculating the expiry time for the timer event.
>>   
>>     
>
>   
>> diff --git a/arch/i386/kernel/setup.c b/arch/i386/kernel/setup.c
>> index d474cd6..fd758f9 100644
>> --- a/arch/i386/kernel/setup.c
>> +++ b/arch/i386/kernel/setup.c
>> @@ -46,6 +46,7 @@
>>  #include <linux/crash_dump.h>
>>  #include <linux/dmi.h>
>>  #include <linux/pfn.h>
>> +#include <linux/kvm_para.h>
>>  
>>  #include <video/edid.h>
>>  
>> @@ -579,6 +580,9 @@ void __init setup_arch(char **cmdline_p)
>>  	vmi_init();
>>  #endif
>>  
>> +#ifdef CONFIG_KVM_CLOCK
>> +	kvmclock_init();
>> +#endif
>>   
>>     
>
> Why is this necessary?  Can't you hook one of the existing pvops?
>   

Something needs to install the pvops in the first place.  Instead of 
adding a kvmclock_init(), it would probably be better to add a single 
kvm_para_init() (as I did in my previous series) and initialize the 
pv_ops for the clock there.

Regards,

Anthony Liguori

>     J
>
>   


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/