Re: [PATCH][Resend] Split kvm_vcpu to support new archs.

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Carsten Otte wrote:
> Avi Kivity wrote:
>   
>> Using previous terminology, mmio is s390 special.  Everyone else does
>> have them.  We can #ifndef them on s390, but we won't duplicate mmio on
>> all other archs.
>>     
> No need to duplicate the code for all other archs: we should think 
> about a functional split here, like having an mmio.c which can be 
> linked in case the architecture has mmio. We have CONFIG_MMIO in the 
> kernel to distinguish that, and CONFIG_PCI and such. This seems way 
> prefereable to me over a bunch of #ifdef CONFIG_ARCH_WHATEVER.
> Any reason why we should do this different on kvm then in the rest of 
> the kernel?
>   

CONFIG_MMIO works too.  I'm not sure mmio.c is warranted, though. 
Modularity can be carried too far.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/