From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH][Resend] Split kvm_vcpu to support new archs. Date: Sun, 14 Oct 2007 08:07:25 +0200 Message-ID: <4711B21D.3080302@qumranet.com> References: <42DFA526FC41B1429CE7279EF83C6BDC808D7E@pdsmsx415.ccr.corp.intel.com> <470F8025.6060001@de.ibm.com> <47107ADA.90204@qumranet.com> <47107DF1.4020403@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, carsteno-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, "Zhang, Xiantao" To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org Return-path: In-Reply-To: <47107DF1.4020403-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Carsten Otte wrote: > Avi Kivity wrote: > >> Using previous terminology, mmio is s390 special. Everyone else does >> have them. We can #ifndef them on s390, but we won't duplicate mmio on >> all other archs. >> > No need to duplicate the code for all other archs: we should think > about a functional split here, like having an mmio.c which can be > linked in case the architecture has mmio. We have CONFIG_MMIO in the > kernel to distinguish that, and CONFIG_PCI and such. This seems way > prefereable to me over a bunch of #ifdef CONFIG_ARCH_WHATEVER. > Any reason why we should do this different on kvm then in the rest of > the kernel? > CONFIG_MMIO works too. I'm not sure mmio.c is warranted, though. Modularity can be carried too far. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/