From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: [PATCH] Fix color problems with sdl on bgr displays
Date: Sun, 14 Oct 2007 15:52:15 +0200 [thread overview]
Message-ID: <47121F0F.9020804@qumranet.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 356 bytes --]
Some kvm users complained that the blue and red channels are flipped on
their displays. Reverting sdl.c rev 1.40 fixed that problem, so
apparently that commit made the problem larger than it was previously.
Attached a patch the removes the commit and fixes the problem. Please
apply.
--
error compiling committee.c: too many arguments to function
[-- Attachment #2: sdl-bgr.patch --]
[-- Type: text/x-patch, Size: 552 bytes --]
Index: sdl.c
===================================================================
RCS file: /sources/qemu/qemu/sdl.c,v
retrieving revision 1.44
diff -u -r1.44 sdl.c
--- sdl.c 17 Sep 2007 08:09:45 -0000 1.44
+++ sdl.c 14 Oct 2007 13:49:37 -0000
@@ -87,7 +87,7 @@
ds->data = screen->pixels;
ds->linesize = screen->pitch;
ds->depth = screen->format->BitsPerPixel;
- if (screen->format->Bshift > screen->format->Rshift) {
+ if (ds->depth == 32 && screen->format->Rshift == 0) {
ds->bgr = 1;
} else {
ds->bgr = 0;
[-- Attachment #3: Type: text/plain, Size: 314 bytes --]
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
[-- Attachment #4: Type: text/plain, Size: 186 bytes --]
_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel
next reply other threads:[~2007-10-14 13:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-14 13:52 Avi Kivity [this message]
[not found] ` <47121F0F.9020804-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-10-14 14:27 ` [Qemu-devel] [PATCH] Fix color problems with sdl on bgr displays Blue Swirl
[not found] ` <f43fc5580710140727r19452244i4ad86cc31b50e7f3-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-10-14 14:36 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47121F0F.9020804@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox