From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Otte Subject: Re: RFC/patch portability: split kvm_vm_ioctl Date: Mon, 15 Oct 2007 10:18:40 +0200 Message-ID: <47132260.9030606@de.ibm.com> References: <1192192452.7630.16.camel@cotte.boeblingen.de.ibm.com> <471077F9.8000703@qumranet.com> Reply-To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" To: Avi Kivity Return-path: In-Reply-To: <471077F9.8000703-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Avi Kivity wrote: > We need to distinguish between x86 specific (only x86 has this) and s390 > special (everyone has it except s390). In the latter case it should > still be in common code to avoid duplication, with a guard to disable > compilation on s390. > > KVM_SET_MEMORY_REGION is in theory applicable to non-s390 but I'd like > to deprecate it, so there's no point in implementing it on non-x86. The > rest are s390 special rather than x86 specific. > > As related previously, KVM_SET_USER_MEMORY_REGION should work for s390 > (with an extra check for the guest phsyical start address). I thought about that all through the weekend. To me, it looks like I want to eliminate "s390 special" as far as possible. In given case, I'll follow Anthonys suggestion and support KVM_SET_USER_MEMORY_REGION. KVM_SET_MEMORY_REGION will also go common, and in case we're pushing the actual port before you deprecate that call, we'll #ifdef CONFIG_ARCH_S390 around it. As for the pic/apic part, I think it is x86 specific. Christian Ehrhardt stated he believes ppc won't have that too. Will create another patch on vm_ioctl that reflects this later today. so long, Carsten ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/