From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Otte Subject: Re: [Patch][RFC]Split kvm_vcpu to support new archs. Date: Mon, 15 Oct 2007 10:32:00 +0200 Message-ID: <47132580.80705@de.ibm.com> References: <42DFA526FC41B1429CE7279EF83C6BDC808C85@pdsmsx415.ccr.corp.intel.com> <471075A4.5030809@qumranet.com> Reply-To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, "Zhang, Xiantao" To: Avi Kivity Return-path: In-Reply-To: <471075A4.5030809-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Avi Kivity wrote: > Zhang, Xiantao wrote: [in struct kvm_vcpu] >> int interrupt_window_open; > arch specific, though maybe it's close enough to generic I thought about this field for a while. What we really want, is that the common code can figure wheter or not it is a good idea to send an interrupt. All architectures (even including s390) could encode an interrupt number in a 64bit value. To me, it looks like a callback for this like int kvm_arch_interrupt_window_open(u64 interrupt); would be the right abstraction. No need to solve this whole thing with this patch though, that aims at splitting kvm_vcpu. so long, Carsten ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/