From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] Add cross compile to top level configuration file Date: Mon, 15 Oct 2007 15:51:09 -0500 Message-ID: <4713D2BD.9040202@codemonkey.ws> References: <1192475533.5811.6.camel@thinkpad> <4713C9D5.3070001@codemonkey.ws> <1192480549.5811.27.camel@thinkpad> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , Avi Kivity To: jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org Return-path: In-Reply-To: <1192480549.5811.27.camel@thinkpad> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Jerone Young wrote: > On Mon, 2007-10-15 at 15:13 -0500, Anthony Liguori wrote: > >> Jerone Young wrote: >> >>> This patch is an improved version of patches sent last week to enable >>> the top level configuration file for cross compile. This currently >>> allows x86 & x86-64 to cross compile. But will soon be sending patches >>> for powerpc embedded once this is accepted. This patches to latest git >>> and is in git format ;-) >>> >>> Signed-off-by: Jerone Young >>> >>> ------------------------------------------------------------------------ >>> >> Why are you only passing --enable-alsa only x86? >> > > Because for our powerpc stuff we actually want different options. ALSA > is not a dependency we want. > Well, you don't want the dependency, but does that mean noone will ever want the dependency on anything but x86? I'm curious why --enable-alsa is here in the first place. QEMU will use SDL audio by default. Perhaps Avi can shed light on why added in the first place? Regards, Anthony Liguori >>> +fi >>> + >>> +qemudir=`pwd`/qemu >>> + >>> +#configure user dir >>> +(cd user; ./configure --prefix="$prefix" --kerneldir="$libkvm_kerneldir" \ >>> + $user_opts --arch="$arch") >>> +(cd qemu; ./configure --target-list=$target_exec \ >>> --disable-kqemu --extra-cflags="-I $PWD/../user" \ >>> --extra-ldflags="-L $PWD/../user" \ >>> --enable-kvm --kernel-path="$libkvm_kerneldir" \ >>> - --enable-alsa \ >>> ${disable_gcc_check:+"--disable-gcc-check"} \ >>> - --prefix="$prefix" >>> + --prefix="$prefix" \ >>> + $qemu_opts --cpu="$arch" >>> >>> >> I don't think this is right. You're using two different --cpu options >> for i386 and x86_64. There really shouldn't be a --cpu option at all >> for x86. >> > > So the --cpu option is actually a hidden option in qemu & is not on the > qemu help page .. who know why it isn't but the it's in the code. > > It makes since though that if you are going to specify cross-prefix= > then there is little reason to specify the cpu on the qemu line. As it > should detect everything from cross compiler. > > I'll test this out and send a new patch with the 2 changes. > > >> Regards, >> >> Anthony Liguori >> >> >>> ) >>> >>> >>> - >>> cat < config.mak >>> +ARCH=$arch >>> PREFIX=$prefix >>> KERNELDIR=$kerneldir >>> WANT_MODULE=$want_module >>> +CC=$cross_prefix$cc >>> EOF >>> - >>> >> >>> ------------------------------------------------------------------------- >>> This SF.net email is sponsored by: Splunk Inc. >>> Still grepping through log files to find problems? Stop. >>> Now Search log events and configuration files using AJAX and a browser. >>> Download your FREE copy of Splunk now >> http://get.splunk.com/ >>> ------------------------------------------------------------------------ >>> >>> _______________________________________________ >>> kvm-devel mailing list >>> kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org >>> https://lists.sourceforge.net/lists/listinfo/kvm-devel >>> >> ------------------------------------------------------------------------- >> This SF.net email is sponsored by: Splunk Inc. >> Still grepping through log files to find problems? Stop. >> Now Search log events and configuration files using AJAX and a browser. >> Download your FREE copy of Splunk now >> http://get.splunk.com/ >> _______________________________________________ >> kvm-devel mailing list >> kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org >> https://lists.sourceforge.net/lists/listinfo/kvm-devel >> > > > ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/