From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] [RESEND] Add cross compile to top level configuration file Date: Tue, 16 Oct 2007 11:59:44 +0200 Message-ID: <47148B90.2020607@qumranet.com> References: <1192475533.5811.6.camel@thinkpad> <4713C9D5.3070001@codemonkey.ws> <1192480549.5811.27.camel@thinkpad> <4713D2BD.9040202@codemonkey.ws> <1192504130.5811.49.camel@thinkpad> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org Return-path: In-Reply-To: <1192504130.5811.49.camel@thinkpad> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Jerone Young wrote: > This new patch removes gcc 3.x checks, as well as adds environment > variables $CFLAGS & $LDFLAGS to include libs to qemu for cross compile. > I was going to add this in another patch. But they should probably go in > now. So an example for power is to include zlib so before running > configure you do: > export LDFLAGS="-L/home/public/zlib-ppc/lib" > export CFLAGS="-I/home/public/zlib-ppc/include" > > Let's not add dependencies on environment variables. Explicit --options please. > Signed-on-by: Jerone Young > > diff -r ff2feafadcac configure > --- a/configure Fri Oct 12 07:35:25 2007 -0500 > +++ b/configure Mon Oct 15 21:52:51 2007 -0500 > @@ -3,32 +3,29 @@ prefix=/usr/local > prefix=/usr/local > kerneldir=/lib/modules/$(uname -r)/build > want_module=1 > -qemu_cc=$(ls /usr/bin/gcc3* /usr/bin/gcc-3* 2>/dev/null | tail -n1) > > +cc=gcc > disable_gcc_check= > +cross_prefix= > +arch=`uname -m` > +target_exec= > > usage() { > cat <<-EOF > Usage: $0 [options] > > Options include: > - > + --arch=ARCH architecture to compile for ($arch) > + --cross-prefix=PREFIX prefix for cross compiler > --prefix=PREFIX where to install things ($prefix) > --with-patched-kernel don't use external module > --kerneldir=DIR kernel build directory ($kerneldir) > - --qemu-cc="$qemu_cc" compiler for qemu (needs gcc3.x) ($qemu_cc) > + --qemu-cc=CC compiler for qemu (needs to be gcc 3.x) > + Not valid if used with --cross-prefix > --disable-gcc-check don't insist on gcc-3.x > - - this will break running without kvm > + CAUTION: using this option may break build > Looks like a step back in terms of the amount of information provided to the user. > while [[ "$1" = -* ]]; do > opt="$1"; shift > @@ -48,11 +45,17 @@ while [[ "$1" = -* ]]; do > want_module= > ;; > --qemu-cc) > - qemu_cc="$arg" > + cc="$arg" > This forces everything to be compiled with $cc, not just qemu? Or is the kernel/ dierctory not affected by this? > +qemudir=`pwd`/qemu > Add quoting so we can pretend we're safe in the presence of whitespace in $PWD. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/