Re: [Patch][RFC]Split kvm_vcpu to support new archs.

Zhang, Xiantao
2007-10-12T10:36:34Z

Carsten Otte wrote:
> Zhang, Xiantao wrote:
>> According to our previous discuss, we proposed a source layout,
>> which contains an "include" directory to hold header files for all
>> archs under drivers/kvm/, and kvm_arch.h will finally go into
>> drivers/kvm/include/kvm-x86/(linked as kvm when compile).
> Right. The thing is, I've started a new header for this purpose
> yesterday. And this should be in the _same_ header, no matter where
> it'll end up. It is the x86 specific header file, currently named
> drivers/kvm/x86.h, which needs to be renamed/moved in the future.

Agree. future rename or remove operation is needed.

>> So, every
>> architecture can defines its own kvm_arch.h for their arch, and
>> compile will choose it per ARCH when compile time. But for now, we
>> can just put it here before another real new arch in. Then, we can
>> remove x86.h, since it is not so common for all archs. :)
>> BTW, header files should be managed with a uniform method, because
>> possible archs, such as IA64, maybe need many ones.
> That's fine with me. But prior to that we'll need to split x86 so that
> it can be relocated in its arch directory different from the common
> kvm location. And until we're there, we use x86.h as a place to store
> x86 specific header content.

OK, I will change it to x86.h, but we also renamed it to such
"kvm_arch.h", because kvm.h will includes it.

> so long,
> Carsten