Re: [Patch][RFC]Split kvm_vcpu to support new archs.

Zhang, Xiantao
2007-10-16T09:55:16Z

Avi Kivity wrote:
> Zhang, Xiantao wrote:
>>
>>>> - u64 ia32_misc_enable_msr;
>>>>
>>>> struct kvm_mmu mmu;
>>>>
>>>>
>>> mmu
>>>
>>
>> About mmu, i am not sure about this. IA64 only need kvm module to
>> allocate and free memory for guests. Most functions related to mmu
>> are useless for IA64. If we put them as common, Maybe we have to
>> define some blank functions.
>>
>>
>
> I meant the mmu is x86 specific.

Sorry for misunderstanding. Should we move out the code logic related
to mmu from kvm_main.c , and put them as arch-specific code ?:)

>>>>
>>> pio is x86 specific
>>>
>>
>> Why see pio as x86 specific? as I know, most archs have port IO
>> access .
>>
>>
>
> Which ones? ppc and s390 don't, and I think ia64 doesn't either?

Yes, IA64 hasn't separate IO address space, and do hasn't Port IO access
with directy IO instructions. But for compatibility with Legacy devices,
all IO ports in devices are sparsely mapped into 64M MMIO space, so we
need to translate them inoto port IO for IO device emulation in
virtualization world. Anyway, this is not a big problem, up to you: )

Thanks
Xiantao