Re: [Patch][RFC]Split kvm_vcpu to support new archs.

Zhang, Xiantao
2007-10-16T10:27:16Z

Avi Kivity wrote:
> Zhang, Xiantao wrote:
>>
>>>> About mmu, i am not sure about this. IA64 only need kvm module to
>>>> allocate and free memory for guests. Most functions related to mmu
>>>> are useless for IA64. If we put them as common, Maybe we have to
>>>> define some blank functions.
>>>>
>>>>
>>>>
>>> I meant the mmu is x86 specific.
>>>
>>
>> Sorry for misunderstanding. Should we move out the code logic
>> related to mmu from kvm_main.c , and put them as arch-specific code
>> ?:)
>>
>>
>
> Yes. But from what I looked, there isn't much mmu code in kvm_main.c,
> only calls to mmu code.

I mean this too. Maybe IA64 can define some blank fucntions called in
kvm_main.c.

>>>>> pio is x86 specific
>>>>>
>>>>>
>>>> Why see pio as x86 specific? as I know, most archs have port IO
>>>> access .
>>>>
>>>>
>>>>
>>> Which ones? ppc and s390 don't, and I think ia64 doesn't either?
>>>
>>
>> Yes, IA64 hasn't separate IO address space, and do hasn't Port IO
>> access with directy IO instructions. But for compatibility with
>> Legacy devices, all IO ports in devices are sparsely mapped into 64M
>> MMIO space, so we need to translate them inoto port IO for IO device
>> emulation in virtualization world. Anyway, this is not a big
>> problem, up to you: )
>>
>
> We can do this translation in userspace, unless there's a device you
> want to emulate in the kernel that uses pio.

Also works in userspace, but maybe need to add some logics for that. :)