From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC] modular dependencies for kvm's qemu Date: Tue, 16 Oct 2007 12:38:04 +0200 Message-ID: <4714948C.50409@qumranet.com> References: <20071016092214.GA13850@tapir> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Carlo Marcelo Arenas Belon Return-path: In-Reply-To: <20071016092214.GA13850@tapir> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Carlo Marcelo Arenas Belon wrote: > Greetings, > > kvm's configure calls qemu's configure with --enable-alsa, making the > existence and use of alsa a dependency; with the import of the latest CVS > qemu, a similar implicit dependency has been added for gnutls (required for > TLS support for qemu's vnc server). > > the following proposed patch (which is a combined patch from a 2 patch series) > allows kvm's configure to enable alsa or disable vnc tls conditionally. > > I am curious if the approach taken for alsa (which is the one that fits what > qemu's configure allows for this case) is acceptable or not, as it will change > the dependency on alsa from being required by default to optional and unless > --enable-alsa is used. > > EOF > @@ -50,6 +52,12 @@ > --qemu-cc) > qemu_cc="$arg" > ;; > + --enable-alsa) > + enable_alsa=1 > + ;; > + --disable-vnc-tls) > + disable_vnc_tls=1 > + ;; > The variables should be initialized so they aren't accidentally picked up from the environment. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/