Re: [RFC] modular dependencies for kvm's qemu

Avi Kivity
2007-10-16T10:38:04Z

Carlo Marcelo Arenas Belon wrote:
> Greetings,
>
> kvm's configure calls qemu's configure with --enable-alsa, making the
> existence and use of alsa a dependency; with the import of the latest CVS
> qemu, a similar implicit dependency has been added for gnutls (required for
> TLS support for qemu's vnc server).
>
> the following proposed patch (which is a combined patch from a 2 patch series)
> allows kvm's configure to enable alsa or disable vnc tls conditionally.
>
> I am curious if the approach taken for alsa (which is the one that fits what
> qemu's configure allows for this case) is acceptable or not, as it will change
> the dependency on alsa from being required by default to optional and unless
> --enable-alsa is used.
>
> EOF
> @@ -50,6 +52,12 @@
> --qemu-cc)
> qemu_cc="$arg"
> ;;
> + --enable-alsa)
> + enable_alsa=1
> + ;;
> + --disable-vnc-tls)
> + disable_vnc_tls=1
> + ;;
>

The variables should be initialized so they aren't accidentally picked
up from the environment.

--
error compiling committee.c: too many arguments to function