From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: Access registers for instructions with ModR/M byte and Mod = 3 Date: Thu, 18 Oct 2007 11:19:50 +0200 Message-ID: <47172536.1010305@qumranet.com> References: <20071017173041.GA8545@hall.aurel32.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Aurelien Jarno Return-path: In-Reply-To: <20071017173041.GA8545-OqXK5JiLQY5aJl8KAwiEcA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Aurelien Jarno wrote: > Ok, next try. This time I have opened the IA32 manual (I should have > done that before), so I hope it is correct. > > > KVM: Access registers for instructions with ModR/M byte and Mod = 3 > > The patch belows changes the access type to register from memory for > instructions that are declared as SrcMem or DstMem, but have a > ModR/M byte with Mod = 3. > > It fixes (at least) the lmsw and smsw instructions on an AMD64 CPU, > which are needed for FreeBSD. > > Applied, thanks. We probably want to move modrm decoding to create a 'modrm_operand' of type 'struct operand' and then simply copy that into c->src or c->dst as needed. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/